Skip to content

Bump pywemo from 0.9.1 to 1.1.0#95951

Merged
frenck merged 1 commit into
home-assistant:devfrom
esev:wemo_110
Jul 8, 2023
Merged

Bump pywemo from 0.9.1 to 1.1.0#95951
frenck merged 1 commit into
home-assistant:devfrom
esev:wemo_110

Conversation

@esev
Copy link
Copy Markdown
Contributor

@esev esev commented Jul 6, 2023

Proposed change

pywemo 1.1.0 includes some improvements for the Long Press feature on WeMo dimmers/switches. I've been running this version for about 2 weeks without issue on 2023.6.2 and on 2023.7.0 starting the same day it was released.

All of the breaking changes from the pywemo 1.0.0 release were addressed in #46797, #72316, #72378, #72400, and #94791.

It would be nice if this could be included in a bug fix release for 2023.7.X, but it's also perfectly fine if it is included in a future monthly release too.

I'm expecting this to help with #75063. I suspect pywemo may have been triggering a bug in specific WeMo devices resulting in slow memory leak that eventually causes them to be in an unavailable state until the physical reset button is pressed. Attempting to more accurately replicate the exact UPnP messages generated by the devices seems to have helped on a WeMo dimmer of mine that was frequently becoming unavailable after 5-7 days. Its uptime is currently 3 weeks.

Those bug fixes are in pywemo==1.1.0. But, sometimes the issue takes a while to appear so it's hard to say with certainty that this fixes the issue. I have therefore not marked this PR as a fix for that issue. I'd like to see if the situation improves for others before closing the issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: wemo small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Jul 6, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 7, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @esev 👍

../Frenck

@frenck frenck added this to the 2023.7.2 milestone Jul 8, 2023
@frenck frenck merged commit abdbea8 into home-assistant:dev Jul 8, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: wemo Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants