Bump pywemo from 0.9.1 to 1.1.0#95951
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
pywemo 1.1.0 includes some improvements for the Long Press feature on WeMo dimmers/switches. I've been running this version for about 2 weeks without issue on 2023.6.2 and on 2023.7.0 starting the same day it was released.
All of the breaking changes from the pywemo 1.0.0 release were addressed in #46797, #72316, #72378, #72400, and #94791.
It would be nice if this could be included in a bug fix release for 2023.7.X, but it's also perfectly fine if it is included in a future monthly release too.
I'm expecting this to help with #75063. I suspect pywemo may have been triggering a bug in specific WeMo devices resulting in slow memory leak that eventually causes them to be in an unavailable state until the physical reset button is pressed. Attempting to more accurately replicate the exact UPnP messages generated by the devices seems to have helped on a WeMo dimmer of mine that was frequently becoming unavailable after 5-7 days. Its uptime is currently 3 weeks.
Those bug fixes are in pywemo==1.1.0. But, sometimes the issue takes a while to appear so it's hard to say with certainty that this fixes the issue. I have therefore not marked this PR as a fix for that issue. I'd like to see if the situation improves for others before closing the issue.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: